Skip to content

ModuleEntryInterceptor sitting before the async invocation interceptor causes traces to place spans in the wrong place #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue May 23, 2024 · 0 comments
Closed

ModuleEntryInterceptor sitting before the async invocation interceptor causes traces to place spans in the wrong place #621

odrotbohm opened this issue May 23, 2024 · 0 comments
Assignees
@odrotbohm
Labels
in: observability Observability support type: bug Something isn't working
Milestone
1.1.5

Comments

@odrotbohm
Copy link
Member

odrotbohm commented May 23, 2024 •
edited
Loading

Back port of GH-615.
@odrotbohm odrotbohm added in: observability Observability support type: bug Something isn't working labels May 23, 2024
@odrotbohm odrotbohm added this to the 1.1.5 milestone May 23, 2024
@odrotbohm odrotbohm self-assigned this May 23, 2024
odrotbohm added a commit that referenced this issue May 23, 2024
@odrotbohm
GH-621 - Make sure we always place the ModuleEntryInterceptor after t…
c80c3e0 
…he AsyncAnnotationAdvisor.

To properly create spans for the actual method invocation, not the async dispatch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: observability Observability support type: bug Something isn't working
Projects
None yet
Milestone
1.1.5
Development

No branches or pull requests
1 participant
@odrotbohm