Feat: Add clippy stackslib, pass indexing_slicing #6188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets stackslib to pass the first lint listed in #6156
This does a couple of things in the refactor beyond just replacing
foo[..]
withfoo.get(..)?
in order to make the usage a little more idiomatic in rust:Some of the previous avoidance of iterators (in MARF in particular) had comments indicating that iterators were slower than the alternatives (for loops, and even manual for loops). I'm not sure if that used to be the case in older versions of rustc, but as of this PR, there was no measurable difference when measured using the MARF benchmarks (with optimizations turned on: I think in unoptimized builds, there is a performance difference).