Fix issue with reading in CSV for models with spaces in name #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a simple fix but would still appreciate a review. @jgabry is busy these days so @mike-lawrence could I interest you in reviewing? |
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 93.17% 92.23% -0.95%
==========================================
Files 12 12
Lines 2873 2832 -41
==========================================
- Hits 2677 2612 -65
- Misses 196 220 +24
Continue to review full report at Codecov.
|
rok-cesnovar
commented
Feb 17, 2021
| "Warning: deprecated language construct used in", | ||
| fixed = TRUE | ||
| ) | ||
| }) |
There was a problem hiding this comment.
This is separate from the rest of the PR. This addressed part of #389 by adding a test deprecation warnings show up.
|
@bbbales2 mind taking a look here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes issue with reading in CSV files for models with spaces in name. Issue reported here.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: