Skip to content

process_data() improvements #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 23, 2021
Merged

Conversation

rok-cesnovar
Copy link
Member

@rok-cesnovar rok-cesnovar commented Aug 22, 2021

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Improves process_data in two ways:

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar, Alexey Stukalov

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

Codecov Report

Merging #538 (c7c70e1) into master (58f0980) will decrease coverage by 1.50%.
The diff coverage is 100.00%.

❗ Current head c7c70e1 differs from pull request most recent head c08647c. Consider uploading reports for the commit c08647c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   92.80%   91.29%   -1.51%     
==========================================
  Files          12       12              
  Lines        3071     3090      +19     
==========================================
- Hits         2850     2821      -29     
- Misses        221      269      +48     
Impacted Files Coverage Δ
R/data.R 99.35% <100.00%> (+0.08%) ⬆️
R/model.R 90.88% <100.00%> (-1.06%) ⬇️
R/install.R 58.33% <0.00%> (-10.50%) ⬇️
R/utils.R 90.71% <0.00%> (-1.43%) ⬇️
R/csv.R 97.76% <0.00%> (-0.90%) ⬇️
R/run.R 95.23% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f0980...c08647c. Read the comment docs.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@jgabry jgabry merged commit e3f20f7 into master Aug 23, 2021
@jgabry jgabry deleted the process_scalars_and_length_1_containers branch August 23, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading matrix with large integral numbers Length-one vectors are incorrectly read as single values
3 participants