Skip to content

Fix handling integers #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Fix handling integers #563

merged 1 commit into from
Sep 30, 2021

Conversation

rok-cesnovar
Copy link
Member

Summary

#538 introduced a bug that caused issues reported on Discourse (https://discourse.mc-stan.org/t/mismatch-in-number-of-dimensions-declared-and-found/24599). This PR fixes that bug.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@rok-cesnovar rok-cesnovar requested a review from jgabry September 30, 2021 19:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #563 (0b5aea6) into master (ea5bc44) will decrease coverage by 1.75%.
The diff coverage is 100.00%.

❗ Current head 0b5aea6 differs from pull request most recent head 11f2585. Consider uploading reports for the commit 11f2585 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
- Coverage   92.98%   91.22%   -1.76%     
==========================================
  Files          12       12              
  Lines        3191     3191              
==========================================
- Hits         2967     2911      -56     
- Misses        224      280      +56     
Impacted Files Coverage Δ
R/data.R 99.35% <100.00%> (ø)
R/install.R 57.56% <0.00%> (-12.47%) ⬇️
R/utils.R 88.88% <0.00%> (-1.39%) ⬇️
R/model.R 92.03% <0.00%> (-0.93%) ⬇️
R/csv.R 97.76% <0.00%> (-0.90%) ⬇️
R/run.R 95.23% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5bc44...11f2585. Read the comment docs.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging now

@jgabry jgabry merged commit d34340d into master Sep 30, 2021
@jgabry jgabry deleted the fix_as_integer_issue branch September 30, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants