Destinations: pass -Xfrontend -validate-tbd-against-ir=none
#6377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
MaxDesiatov
changed the title
-Xfrontend -validate-tbd-against-ir=none-Xfrontend -validate-tbd-against-ir=none
compnerd
approved these changes
Apr 4, 2023
| @@ -26,6 +26,10 @@ target_link_libraries(CrossCompilationDestinationsTool PUBLIC | |||
| # NOTE(compnerd) workaround for CMake not setting up include flags yet | |||
| set_target_properties(CrossCompilationDestinationsTool PROPERTIES | |||
| INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_Swift_MODULE_DIRECTORY}) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I suppose that we should file an issue and tag it here so that we can clean this up.
There was a problem hiding this comment.
Done in swiftlang/swift#64900
There was a problem hiding this comment.
can we make this conditional on windows + add a comment why we need this?
MaxDesiatov
commented
Apr 4, 2023
MaxDesiatov
commented
Apr 4, 2023
This fixes an issue with the Windows build highlighted in #6361 (comment)
MaxDesiatov
force-pushed
the
maxd/disable-tbd-validation
branch
from
6dcc3c3 to
c4f74ab
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows |
neonichu
approved these changes
Apr 4, 2023
|
I think that this should no longer be needed given that swiftlang/swift#64920 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the Windows build introduced with the conversion of
SwiftDestinationTooltoAsyncParsableCommand, as reported at #6361 (comment)