TDBGen: add a workaround for a workaround for async PWT #64920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
force-pushed
the
public-your-private
branch
from
3793566 to
ca7850b
Compare
|
@swift-ci please test |
compnerd
force-pushed
the
public-your-private
branch
from
ca7850b to
f50ed93
Compare
|
@swift-ci please test |
tshortli
approved these changes
Apr 4, 2023
|
@swift-ci please test Windows platform |
compnerd
force-pushed
the
public-your-private
branch
from
f50ed93 to
2b90205
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Apr 4, 2023
|
Will we need this on |
|
@DougGregor yea, we will >.< |
|
@swift-ci please test macOS platform |
|
@swift-ci test macos |
compnerd
force-pushed
the
public-your-private
branch
from
2b90205 to
ce001f7
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci test macos |
|
:sigh: However, the test is marked with: |
|
REQUIRES: CONCURRENCY describes where we’re building, which supports concurrency, not what the test is targeting. The test is targeting 10.13, so it fails. I think you can add -disable-availability-checking to the test and get it working. |
When a protocol witness thunk is formed to a serialised protocol containing an `async` function, the async function pointer to the conformance needs to be made public due to a SIL Verifier check failure (reference to a non-fragile function from within a public fragile function). Add a stop-gap solution of rolling an extra emission for a private symbol as a public symbol to avoid the error (the underlying issue has been open for ~6y and counting as of this commit). This was identified by swift-package-manager (swiftlang#64900). Thanks to @DougGregor and @aschwaighofer for the discussion on this!
compnerd
force-pushed
the
public-your-private
branch
from
ce001f7 to
0301e03
Compare
|
@swift-ci please test |
This is not a request for a change to this PR but I just want to note that in most tests I'd prefer it if folks just added the right availability to declarations that depend on concurrency so that we're testing that availability checking behaves correctly. The declarations just need |
|
@swift-ci please test macOS platform |
|
|
CC: @shahmishal |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a protocol witness thunk is formed to a serialised protocol containing an
asyncfunction, the async function pointer to the conformance needs to be made public due to a SIL Verifier check failure (reference to a non-fragile function from within a public fragile function). Add a stop-gap solution of rolling an extra emission for a private symbol as a public symbol to avoid the error (the underlying issue has been open for ~6y and counting as of this commit).This was identified by swift-package-manager (#64900).