Emit a deprecation warning for --skip-update
#7229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://117765416
|
@swift-ci please test |
MaxDesiatov
reviewed
Jan 8, 2024
| @@ -395,6 +395,10 @@ public final class SwiftTool { | |||
| return workspace | |||
| } | |||
|
|
|||
| if options.resolver.skipDependencyUpdate { | |||
| self.observabilityScope.emit(warning: "'--skip-update' option is deprecated and will be removed in a future release") | |||
There was a problem hiding this comment.
Is there a replacement for --skip-update? What exactly should be used instead of it?
There was a problem hiding this comment.
There's no replacement for it since it never really did what people wanted. Eventually maybe something like #4705 could be used as a replacement.
MaxDesiatov
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://117765416