Skip to content

Emit a deprecation warning for --skip-update #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Emit a deprecation warning for --skip-update #7229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/CoreCommands/SwiftTool.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,10 @@ public final class SwiftTool {
return workspace
}

if options.resolver.skipDependencyUpdate {
self.observabilityScope.emit(warning: "'--skip-update' option is deprecated and will be removed in a future release")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a replacement for --skip-update? What exactly should be used instead of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no replacement for it since it never really did what people wanted. Eventually maybe something like #4705 could be used as a replacement.

}

let delegate = self.workspaceDelegateProvider(
self.observabilityScope,
self.observabilityHandler.print,
Expand Down