Show progress bar while downloading Swift SDK bundles #7315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The download operation takes a while, and it makes users feel like SwiftPM is stuck. This patch adds a progress indicator to the download operation to make it clear that SwiftPM is still working and how much work is left.
kateinoigakukun
requested review from
bnbarham,
MaxDesiatov,
neonichu and
tomerd
as code owners
|
@swift-ci Please test |
kateinoigakukun
commented
Feb 3, 2024
| @@ -47,7 +49,10 @@ public struct InstallSwiftSDK: SwiftSDKSubcommand { | |||
| swiftSDKsDirectory: swiftSDKsDirectory, | |||
| fileSystem: self.fileSystem, | |||
| observabilityScope: observabilityScope, | |||
| outputHandler: { print($0.description) } | |||
| outputHandler: { print($0.description) }, | |||
| downloadProgressAnimation: ThrottledProgressAnimation( | |||
There was a problem hiding this comment.
Progress animation is throttled by timer to avoid too flickering animation triggered by HTTPClient's too frequent progress reports.
There was a problem hiding this comment.
Since swift-tools-support-core is deprecated, would you mind adding this new types to the Basics module in SwiftPM instead?
There was a problem hiding this comment.
Okay, move it to SwiftPM repo
MaxDesiatov
requested changes
Feb 5, 2024
To avoid intoroducing a new code in TSC
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci Please test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The download operation takes a while, and it makes users feel like SwiftPM is stuck.
Modifications:
This patch adds a progress indicator to the download operation to make it clear that SwiftPM is still working and how much work is left.
Screen.Recording.2024-02-03.at.19.48.14.mov