Add ThrottledProgressAnimation to avoid too frequent animation updates
#465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci Please test |
kateinoigakukun
force-pushed
the
pr-7dbd761a595384925c9a781feeac62bc4813c533
branch
from
b35c0c7 to
cdc7534
Compare
|
@swift-ci Please test |
kateinoigakukun
force-pushed
the
pr-7dbd761a595384925c9a781feeac62bc4813c533
branch
from
cdc7534 to
60766d2
Compare
|
@swift-ci Please test |
Too frequent updates to the progress animation can cause flickering and can prevent kernel from reflecting the terminal size change on `ioctl`.
kateinoigakukun
force-pushed
the
pr-7dbd761a595384925c9a781feeac62bc4813c533
branch
from
60766d2 to
30fb290
Compare
|
@swift-ci Please test |
|
Closing in favor of swiftlang/swift-package-manager@81d16d1 |
kateinoigakukun
deleted the
pr-7dbd761a595384925c9a781feeac62bc4813c533
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too frequent updates to the progress animation can cause flickering and can prevent kernel from reflecting the terminal size change on
ioctl.This PR introduces a new ProgressAnimation class
ThrottledProgressAnimation, which throttles update frequency of underlying animation.This will be used by swiftlang/swift-package-manager#7315 to throttle too frequent
URLSession's delegation calls.