Provide deprecation messages for PackagePlugin.Path
#7677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `PackagePlugin.Path` was deprecated in favor of `PackagePlugin.URL`, we should provide explicit deprecation messages that redirect plugin authors to the recommended use of the `URL` type. (cherry picked from commit d212230)
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci test |
bnbarham
approved these changes
Jun 18, 2024
neonichu
reviewed
Jun 18, 2024
MaxDesiatov
commented
Jun 18, 2024
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
added
the
no functional change
MaxDesiatov
added a commit
that referenced
this pull request
Jun 18, 2024
Cherry-pick of #7677. **Explanation**: As `PackagePlugin.Path` was deprecated in favor of `PackagePlugin.URL`, we should provide explicit deprecation messages that redirect plugin authors to the recommended use of the `URL` type. **Scope**: Isolated to the `PackagePlugin` module. **Risk**: low, this change is technically NFC. **Testing**: N/A as it is NFC. **Issue**: rdar://128324920 **Reviewer**: @bnbarham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
PackagePlugin.Pathwas deprecated in favor ofPackagePlugin.URL, we should provide explicit deprecation messages that redirect plugin authors to the recommended use of theURLtype.rdar://128324920