Skip to content

[6.0] Provide deprecation messages for PackagePlugin.Path #7683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

MaxDesiatov
Copy link
Contributor

Cherry-pick of #7677.

Explanation: As PackagePlugin.Path was deprecated in favor of PackagePlugin.URL, we should provide explicit deprecation messages that redirect plugin authors to the recommended use of the URL type.
Scope: Isolated to the PackagePlugin module.
Risk: low, this change is technically NFC.
Testing: N/A as it is NFC.
Issue: rdar://128324920
Reviewer: @bnbarham

As `PackagePlugin.Path` was deprecated in favor of `PackagePlugin.URL`, we should provide explicit deprecation messages that redirect plugin authors to the recommended use of the `URL` type.

(cherry picked from commit d212230)
(cherry picked from commit d702c1c)
@MaxDesiatov MaxDesiatov requested a review from a team as a code owner June 18, 2024 20:52
@MaxDesiatov MaxDesiatov changed the title Maxd/plugins path deprecation 6.0 [6.0] Provide deprecation messages for PackagePlugin.Path Jun 18, 2024
@MaxDesiatov MaxDesiatov added documentation swift 6.0 Related to Swift 6.0 release branch labels Jun 18, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) June 18, 2024 20:56
@MaxDesiatov MaxDesiatov added the no functional change No user-visible functional changes included label Jun 18, 2024
@MaxDesiatov MaxDesiatov merged commit c56e4fc into release/6.0 Jun 18, 2024
5 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/plugins-path-deprecation-6.0 branch June 18, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation no functional change No user-visible functional changes included swift 6.0 Related to Swift 6.0 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants