-
Notifications
You must be signed in to change notification settings - Fork 15
[swift-build] Update vm images - no Python 3.9 #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mhegazy
wants to merge
8
commits into
main
Choose a base branch
from
mhegazy/vm-images-no-python
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60e7bde
to
5d0b732
Compare
5d0b732
to
582019a
Compare
tristanlabelle
approved these changes
Jun 30, 2025
Steelskin
requested changes
Jun 30, 2025
@@ -692,7 +692,10 @@ jobs: | |||
ref: ${{ inputs.swift_revision }} | |||
path: ${{ github.workspace }}/SourceCache/swift | |||
show-progress: false | |||
|
|||
- name: Setup python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have this upstream. Is there a reason why this cannot be upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upstream PR: compnerd/swift-build#983
Update the CMake configuration to match the changes done in swiftlang/swift#82210.
For now, this is used to remove the workaround to downgrade the MSVC build tools version. Once the Windows static build is ready, we will also need this mechanism to use a more recent toolchain to build the early swift-driver statically.
Also set up the repo to use uv.
5433206
to
582019a
Compare
7de42e9
to
856213b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new set of VM images created without python 3.9 pre-installed following https://github.com/thebrowsercompany/arc/pull/42096
Changes
Testing