Skip to content

Fix: Correct undefined data reference in InviteButton component #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Seol-JY
Copy link
Contributor

@Seol-JY Seol-JY commented Jan 16, 2025

Changes

  • Fix undefined data.name reference in InviteButton component
  • Use name prop directly from component props

Problem

The InviteButton component was trying to access data.name which doesn't exist in its scope, causing potential runtime errors.

Copy link

vercel bot commented Jan 16, 2025

@Seol-JY is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@Kimbangg Kimbangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Seol-JY thank you! LGTM 💯

@Kimbangg Kimbangg merged commit ad84ed3 into toss:main Jan 16, 2025
1 check failed
kaehehehe added a commit to kaehehehe/frontend-fundamentals that referenced this pull request Jan 17, 2025
kaehehehe added a commit to kaehehehe/frontend-fundamentals that referenced this pull request Jan 18, 2025
raon0211 pushed a commit that referenced this pull request Jan 18, 2025
* chore: create ja folder and copy files

* docs: translate into japanese

* docs: translate into japanese

* docs: translate for japanese

* docs: reflect #78

* docs: reflect #93

* docs: reflect #97

* docs: update use-user.md (#101)

* docs: reflect #102

* docs: reflect #116

* docs: fix disabled prop code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants