Skip to content

Fix: Inconsistencies in user policy code examples #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Seol-JY
Copy link
Contributor

@Seol-JY Seol-JY commented Jan 15, 2025

Changes

  • Standardize button text and permission properties across all examples
  • Align code implementations with the original requirements
  • Fix property naming to ensure consistent behavior

Before & After Preview

Before: Mixed use of "Read"/"View" buttons and "canRead"/"canView" properties
After: Consistent use of "View" buttons and "canView" properties throughout examples

Copy link

vercel bot commented Jan 15, 2025

@Seol-JY is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@Seol-JY Seol-JY changed the title Fix: I nconsistencies in user policy code examples Fix: Inconsistencies in user policy code examples Jan 15, 2025
@Seol-JY Seol-JY force-pushed the fix/user-policy-consistency branch from e08260f to 7032c83 Compare January 15, 2025 13:47
Copy link
Member

@Kimbangg Kimbangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kimbangg Kimbangg merged commit 65bc54c into toss:main Jan 16, 2025
1 check failed
kaehehehe added a commit to kaehehehe/frontend-fundamentals that referenced this pull request Jan 17, 2025
@Seol-JY Seol-JY mentioned this pull request Jan 18, 2025
19 tasks
kaehehehe added a commit to kaehehehe/frontend-fundamentals that referenced this pull request Jan 18, 2025
raon0211 pushed a commit that referenced this pull request Jan 18, 2025
* chore: create ja folder and copy files

* docs: translate into japanese

* docs: translate into japanese

* docs: translate for japanese

* docs: reflect #78

* docs: reflect #93

* docs: reflect #97

* docs: update use-user.md (#101)

* docs: reflect #102

* docs: reflect #116

* docs: fix disabled prop code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants