Skip to content

Feat: Implement dark mode image support in markdown #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

Feat: Implement dark mode image support in markdown #129

merged 1 commit into from
Jan 22, 2025

Conversation

Seol-JY
Copy link
Contributor

@Seol-JY Seol-JY commented Jan 21, 2025 •
edited
Loading

  • Suggest adding support for dark mode optimized images in markdown documents.
  • This will enhance readability by allowing documents to display different images based on the user's theme preference.

See: vuejs/vitepress#3560

Before

before_light before_dark
Light Dark

After

after_light after_dark
Light Dark

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025

@Seol-JY is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Kimbangg
Kimbangg approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@Kimbangg Kimbangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@Kimbangg Kimbangg merged commit 073c4ef into toss:main Jan 22, 2025
1 check failed
@Seol-JY Seol-JY mentioned this pull request Jan 28, 2025
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimbangg Kimbangg Kimbangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Seol-JY @Kimbangg