Skip to content

docs: improve item-edit-modal.md by adding abstraction concepts (#77) #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Sangminnn
Copy link
Contributor

@Sangminnn Sangminnn commented Jan 23, 2025

📝 Key Changes

Through this discussion, i improve the explanation of props drilling by adding context about abstraction removal.

When related documents are created in the future, i hope they will be linked here.

🖼️ Before and After Comparison

  • Add context about abstraction removal in item-edit-modal.md, /ja/item-edit-modal.md, /en/item-edti-modal.md

Copy link

vercel bot commented Jan 23, 2025

@Sangminnn is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@Kimbangg Kimbangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@Kimbangg Kimbangg merged commit 8857126 into toss:main Jan 24, 2025
1 check failed
@Sangminnn Sangminnn deleted the docs/item-edit-modal-document branch January 24, 2025 01:37
@Seol-JY Seol-JY mentioned this pull request Jan 28, 2025
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants