Skip to content

Fix: Improve grammar and localize link #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Conversation

clicelee
Copy link
Contributor

📝 Key Changes

  • Revised grammar considering natural flow submit-button.md
  • Replaced the Yes24 link with an Amazon link for localization, as Yes24 is not commonly used in English-speaking countries and Amazon is a widely recognized online bookstore. condition-name.md

🖼️ Before and After Comparison

Simple text corrections in English documentation files. No visual changes.

- Replaced the Yes24 link for "The Programmer's Brain" with an Amazon link for localization.
- Revised grammar considering natural flow
Copy link

vercel bot commented Jan 28, 2025

@clicelee is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@milooy milooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milooy milooy merged commit ea53d0c into toss:main Jan 28, 2025
1 check failed
@clicelee
Copy link
Contributor Author

The link still redirects to Yes24, so I’ve opened a new PR. I apologize for missing the incorrect link in my previous update and have corrected it in new submission.
Thank you for taking the time to review my changes again, I truly appreciate your understanding and support.

@owonie owonie mentioned this pull request Jan 29, 2025
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants