Skip to content

Fix: Badge Component Not Rendering #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

Seol-JY
Copy link
Contributor

@Seol-JY Seol-JY commented Feb 1, 2025

📝 Key Changes

  • Added DefaultTheme import from vitepress/theme
  • Extended DefaultTheme in configuration to inherit base components
  • Fixed by following the solution from vuejs/vitepress#1576

The Badge component in VitePress is part of the DefaultTheme package. Initially, we couldn't access it because we tried implementing a custom theme without importing DefaultTheme.

🖼️ Before and After Comparison

Finally, the badge is visible!

before after
Before After

Copy link

vercel bot commented Feb 1, 2025

@Seol-JY is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@milooy milooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an issue I kept thinking about fixing but never got around to—thanks for taking care of it! 😊

@milooy milooy merged commit b9f1f19 into toss:main Feb 2, 2025
1 check failed
Kyujenius pushed a commit to Kyujenius/frontend-fundamentals that referenced this pull request Feb 3, 2025
milooy pushed a commit that referenced this pull request Feb 4, 2025
* fix: change LCP image from png to webp

* docs: 간체 중국어 번역 (#120)

* chore: create ch files

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* docs: translate into simplified chinese

* refactor: substitute with suitable terms

* docs: translate into simplified chinese

* feat: add chSearch

* fix: change chSearch option

* fix: fix typo with inspection

* �fix: fix typo in hidden-logic.md

同时 -> 同事

Co-authored-by: Jinyeong Seol <[email protected]>

* feat: implement dark mode image support in markdown

* docs: improve item-edit-modal.md by adding abstraction concepts

* fix: correct localized link

---------

Co-authored-by: Jinyeong Seol <[email protected]>

* Fix: Corrected localized link to Amazon (#141)

- The link was still redirecting to Yes24, so the link was updated properly

* Fix: Correct import path and Add Chinese on Giscus language  (#144)

* Fix: Ensure Giscus supports Chinese
* Fixed an issue where the Chinese locale was not applied in Giscus

* Fix: Correct import path for Chinese locale
* Fixed an incorrect import path in  ( → ).

* Revert: yarn.lock

* �Fix: Add missing syntax and normalize Auth Token usage (#145)

* fix: Add missing 'from' keyword in import statement

* fix: Add missing period in email validation error message(ko)

* fix: add auth token to HTTP header

* fix: resolve badge component rendering issue by extending default theme (#146)

* feat: add webp Image in chinese ver.

---------

Co-authored-by: Owon <[email protected]>
Co-authored-by: Jinyeong Seol <[email protected]>
Co-authored-by: 𝒄𝒍 𝒊 𝒄 𝒆 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants