-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Remove all ImageSharp.Web Processors and then re-add in the correct order #11241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all ImageSharp.Web Processors and then re-add in the correct order #11241
Conversation
Hi there @Jeavon, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, thanks @Jeavon
Cherry picked to 9.0.1 |
@Jeavon Nice catch and good example of why it really needs to use the processing order from the URL! 💪🏻 The linked PR just got merged and ImageSharp.Web 1.0.4 is released, so we can update to this version and remove these work-arounds 😄 |
Hi there @Jeavon, First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 31st, 2021. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏 We have blogged about this year's hacktoberfest in a recap post, have a read about at all the achievements for this year! The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
Currently, the order in which the ImageSharp processors are registered determines the order of processing so in Umbraco we currently lose the ability, for example, to set the background colour as the resize command comes after the bgcolor processor.
e.g.
sample.png?width=503&height=300&rmode=pad&bgcolor=red
does not work, it does with this PRIt's likely in ImageSharp.Web 1.0.4 the order will be determined by the querystrings but not currently with 1.0.3 SixLabors/ImageSharp.Web#182
This PR removes and re-adds all the built-in processors in the correct order so all commands work.