Update to SixLabors.ImageSharp.Web 1.0.4 and remove processing order workarounds #11349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test for textbox max length * remove leftover comment Co-authored-by: Jesper <[email protected]>
…ms (#11219) Changed the case of `BlockList` to `blocklist` as it breaks on Unix/Linux.
Thanks @lauraneto - reviewed this and your fix solves the issue. #h5yr
…1261) * Add ModelsBuilder unit tests to cover Inheritance and Composition * add name to GenerateSimpleType test
* Added support for Smtp PickupDirectory * Add reference to the implementation outline by MailKit Co-authored-by: Bjarke Berg <[email protected]> Co-authored-by: Bjarke Berg <[email protected]>
* Added missing GetCropUrl overload for MediaWithCrops with the extra configuration options The missing overload would mean that if anyone tried to use the extra options with MediaWithCrops, they would be using the IPublishedContent extension method instead. This would cause several issues, like not loading the local crops and returning null for a lot of scenarios that should work. * Added documentation to the added overload * Use extension method
A fallback for browsers that don't support `contain: content`, to make sure the positioning context is correct
* Remove remaining web.config references in translation files so it will fallback to the correct English text * Remove final reference to web.config in config/lang ru errorChangingProviderPassword Co-authored-by: Paul Johnson <[email protected]>
1 task
# Conflicts: # src/Umbraco.Tests.AcceptanceTest/cypress/integration/Users/users.ts # src/Umbraco.Web.UI/umbraco/config/lang/cy.xml # src/Umbraco.Web.UI/umbraco/config/lang/da.xml # src/Umbraco.Web.UI/umbraco/config/lang/en.xml # src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml # src/Umbraco.Web.UI/umbraco/config/lang/it.xml # src/Umbraco.Web.UI/umbraco/config/lang/nl.xml # tests/Umbraco.Tests.AcceptanceTest/cypress/integration/DataTypes/dataTypes.ts
|
I made an oopsie here and unfortunately merged v9/dev into this PR instead of contrib, thanks to Ronald for changing the target 🙈 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageSharp.Web 1.0.4 is released, that contains the bugfix to use the processing order from the URL (instead of DI registration). This makes the workarounds added in the following PRs obsolete:
Prerequisites
Description
Because the fix in ImageSharp.Web might result in different generated images, it's recommended to delete
/umbraco/Data/TEMP/MediaCache(or wherever you have configured the ImageSharp.Web cache, like Azure Blob Storage).This PR can be tested by ensuring the image crop URLs generate the same/correct image, as mentioned in #10623 (comment) and #11241 (comment).
The image crop URL in the default
ImageSharpImageUrlGeneratorimplementation already uses the correct parameter order. We could switch the focal pointrxyand cropcc, so all resize commands are added after the crop command, but these values are/should never be used at the same time anyway (it either uses the focal point or a crop).