hotfix: context provider should not destroy instance #18864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This hotfix addresses an issue where the context provider was erroneously destroying its instance. The proposed changes remove the destroy call in favor of preserving the instance so that it can potentially be re-provided later.
- Removing the call to the destroy() method on the instance
- Updating the comment to reflect the intended behavior
src/Umbraco.Web.UI.Client/src/libs/context-api/provide/context-provider.ts
Outdated
Show resolved
Hide resolved
…-provider.ts Co-authored-by: Copilot <[email protected]>
madsrasmussen
approved these changes
Mar 31, 2025
madsrasmussen
deleted the
v15/hotfix/15_3_context_provider_should_not_destroy_instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18805