Skip to content

Use StringComparison.Ordinal in hot paths #18893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

enkelmedia
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Uses StringComparison.Ordinal for checks in code hot paths according to this issue:

#18870

Copy link

Hi there @enkelmedia, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan
Copy link
Member

Hey @enkelmedia, good stuff, thanks! And a nice performance update! Next time, can you please be mindful of formatting? I added a lot of spaces for you in this commit 😉 617f24e

Thanks again! 👍

@nul800sebastiaan nul800sebastiaan merged commit 1dd10ea into umbraco:contrib Apr 1, 2025
5 of 8 checks passed
@nul800sebastiaan nul800sebastiaan added release/15.4.0 community/pr category/performance Fixes for performance (generally cpu or memory) fixes type/improvement labels Apr 1, 2025
@enkelmedia
Copy link
Contributor Author

Sorry @nul800sebastiaan 🤦🏼‍♂️ Thanks for fixing them, I will keep this in mind in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/performance Fixes for performance (generally cpu or memory) fixes community/pr release/15.4.0 type/improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants