Avoid unneeded Dictionary operations

[Henr1k80]

Prerequisites

• I have added steps to test this contribution in the description below

Description

Avoid unneeded Dictionary operations

[github-actions]

Hi there @Henr1k80, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nul800sebastiaan]

Hey @Henr1k80 - thanks for this contribution and the other ones over the past few weeks.

However, after reviewing your recent PRs we've encountered some challenges:

• Quite a few of the changes you're making are difficult to review, clearly you've thought these through very well but the descriptions on the PRs do not give a lot of guidance. Some things are obvious but it takes quite a long time to figure out some of the not so obvious ones
• It's unclear whether these optimizations provide significant real-world performance improvements. We need concrete evidence, such as benchmark results, to justify the complexity of these changes.
• Some of the proposed code changes reduce readability, which can hinder future maintenance and collaboration.
• Our contribution guidelines emphasize that we generally do not accept PRs that solely refactor code without demonstrating clear benefits.

I don't mean to discourage you but all these factors lead to reviews being slow or not happening at all as it's complex and we work with a volunteer team who doesn't always have the time or expertise to follow through.

Therefore, for future contributions of this type, I will give some suggestions on how you can help us and help yourself at the same time:

• As much as possible, try to explain the rationale behind each optimization and its potential impact.
• One thing that really makes us eager to dig in is benchmark results that demonstrate the performance improvements achieved. A good example can be found on this PR: Use StringComparison.Ordinal in hot paths #18893
• Prioritize code readability and maintainability. If complex optimizations are necessary in hot paths, please add detailed comments explaining the logic.

With some extra attention it will definitely be great to get some more performance updates in, so I hope we can help each other going forward!

Thanks again, this one I have reviewed now and is good to go.