Skip to content

Internalize uuid package #18955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 8, 2025

Conversation

madsrasmussen
Copy link
Contributor

This PR internalizes the uuid package so it is no longer available as an external import.

Breaking change:
It is no longer possible to import from @umbraco-cms/backoffice/external/uuid;

Replacement:
The same functionality can be found on the UmbId class imported from @umbraco-cms/backoffice/id;

import { UmbId } from '@umbraco-cms/backoffice/id';

const id = UmbId.new();
const isValid = UmbId.validate(id);

@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 12:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
  • src/Umbraco.Web.UI.Client/package.json: Language not supported
  • src/Umbraco.Web.UI.Client/src/packages/core/package.json: Language not supported
  • src/Umbraco.Web.UI.Client/tsconfig.json: Language not supported

@madsrasmussen madsrasmussen changed the title V16: Internalize uuid package Internalize uuid package Apr 7, 2025
@madsrasmussen madsrasmussen added the category/dx Developer experience label Apr 7, 2025
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) April 8, 2025 10:10
* move diff from external to core utils

* Delete package-lock.json
@nielslyngsoe nielslyngsoe merged commit 6aa4714 into v16/dev Apr 8, 2025
26 of 27 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/task/uuid-package-local-dependencies branch April 8, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants