Move "diff" from external to core/utils #18961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsrasmussen
added
release/16.0.0
category/breaking
category/dx
nielslyngsoe
approved these changes
Apr 8, 2025
nielslyngsoe
merged commit 7246939
into
v16/task/uuid-package-local-dependencies
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on #18955
This PR moves the diff package so it is no longer available as an external import. I have placed this library in utils because it might make sense at one point to use the
diffJsonfor the "Discard Changes" functionality.Breaking change:
It is no longer possible to import from
@umbraco-cms/backoffice/external/diff;Replacement:
The same functionality can be found in the utils module imported from
@umbraco-cms/backoffice/utils;Notice the
Changetype has been renamed toUmbDiffChange