V16: Removes all generic Created, Saved, and Deleted notifications #19119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the generic success notifications for "Created", "Saved", and "Deleted" actions in the Backoffice repository to reduce UI noise in the new design.
- Removed notification-related imports and context consumption.
- Deleted notification invocations within the create, update, and delete flows.
madsrasmussen
approved these changes
Apr 23, 2025
|
Seems alot of the E2E tests are reliant on reading the success notifications, to ensure that the operation succeded 🙈 |
…//github.com/umbraco/Umbraco-CMS into v16/feature/no-generic-success-notifications
This was referenced Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation behind this pull request is to put an end to the bloat of success notifications in the Backoffice. In former times, the Backoffice had a very subtle notification bar and thus could show notifications without bothering the user too much. With the new Backoffice, the notification bubble has become a lot more visible, but so have all other visual elements to tell the user that an action has succeeded or not.
This is why we think we can bluntly remove the (admittedly hardcoded) generic success notification bubbles for "Created", "Saved", and "Deleted".
The UI should reflect if the action has been completed in other ways, such as redirecting to the newly created entity automatically and/or updating the trees automatically.