Make Database connection in the config optional #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kouylekov-usit hold on, we can't remove 3.8 tests while the project is still targeting >=3.8. Not just 3.8 having issues either, the updated tsd-api-client broke tests on other versions too |
haatveit
force-pushed
the
make-db-optional
branch
from
f9c57b5 to
2abbf53
Compare
haatveit
approved these changes
Nov 1, 2024
Also moved it to dev dependencies as it's only used for tests.
haatveit
force-pushed
the
make-db-optional
branch
from
b3ba6fa to
564dc69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also in this pull reques: