-
Notifications
You must be signed in to change notification settings - Fork 1.7k
CLI fixes for aws and environment modifications #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI fixes for aws and environment modifications #1713
Conversation
environment variables. Closes usebruno#1255
@scottlaplante Would love to get these fixes in.
Other than #1255, what is the second issue ? Also, I need a bit more clarity regarding the changes related to If not, can you share a sample collection that reproduces the issue? |
The second issue, mentioned in commit message d7e2e, is #1508. I'm happy to get on a call and demonstrate the new behavior (I reserved a time, thanks). I'll also see if I can put together a small collection that showcases the collectionVariables changes. |
@helloanoop thanks for the call today. I've taken a second look and it turns out that setting the |
It was nice talking to you @scottlaplante ! Thank's for taking the time. Merged! |
Description
The two github issues that are being closed with this PR did not contain descriptions of the underlying (small) issues in the CLI code. Here's more context:
This PR address both of those issues.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.