Skip to content

CLI fixes for aws and environment modifications #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scottlaplante
Copy link
Contributor

@scottlaplante scottlaplante commented Mar 3, 2024

Description

The two github issues that are being closed with this PR did not contain descriptions of the underlying (small) issues in the CLI code. Here's more context:

  1. The CLI code was not interpolating the AWS-centric values. Now it is.
  2. When running a folder via command line, the post-request script of request 1 wants to edit the runtime environment of the Bru object that the CLI instantiated. The environment object that was passed into the post-request script function was correctly being modified, but was not affecting the runtime environment for the folder.

This PR address both of those issues.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop
Copy link
Contributor

@scottlaplante Would love to get these fixes in.

The two github issues that are being closed with this PR did not contain descriptions of the underlying (small) issues in the CLI code.

Other than #1255, what is the second issue ?

Also, I need a bit more clarity regarding the changes related to collectionVariables
Would you be willing to get on a call and help me with it?
My cal link is: https://cal.com/helloanoop/30min

If not, can you share a sample collection that reproduces the issue?

@scottlaplante
Copy link
Contributor Author

The second issue, mentioned in commit message d7e2e, is #1508.

I'm happy to get on a call and demonstrate the new behavior (I reserved a time, thanks). I'll also see if I can put together a small collection that showcases the collectionVariables changes.

@scottlaplante
Copy link
Contributor Author

@helloanoop thanks for the call today. I've taken a second look and it turns out that setting the __name__ was the only change required in order to preserve environment and collection variables between subsequent requests when running a folder.

@helloanoop helloanoop merged commit 3ee7606 into usebruno:main Mar 12, 2024
@helloanoop
Copy link
Contributor

It was nice talking to you @scottlaplante ! Thank's for taking the time.

Merged!
Will cut a release in the next two hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants