Skip to content

CLI fixes for aws and environment modifications #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2024
Merged

CLI fixes for aws and environment modifications #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7e2e75
Interpolate awsv4 values to support them including templated values.
scottlaplante Mar 3, 2024
9320b8f
change to let to allow for rewrite; rename to envVariables for consis…
scottlaplante Mar 3, 2024
7c94c9e
When running via CLI, preserve changes to collection variables and
scottlaplante Mar 3, 2024
1f0fe94
Closes #1255 - set well known variable name on environment
scottlaplante Mar 3, 2024
14a0f44
Revert "When running via CLI, preserve changes to collection variable…
scottlaplante Mar 12, 2024
7d3c2f0
Revert "change to let to allow for rewrite; rename to envVariables fo…
scottlaplante Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/bruno-cli/src/commands/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ const handler = async function (argv) {
const envBruContent = fs.readFileSync(envFile, 'utf8');
const envJson = bruToEnvJson(envBruContent);
envVars = getEnvVars(envJson);
envVars.__name__ = env;
}

if (envVar) {
Expand Down
11 changes: 10 additions & 1 deletion packages/bruno-cli/src/runner/interpolate-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,16 @@ const interpolateVars = (request, envVars = {}, collectionVariables = {}, proces
delete request.auth;
}

return request;
if (request.awsv4config) {
request.awsv4config.accessKeyId = _interpolate(request.awsv4config.accessKeyId) || '';
request.awsv4config.secretAccessKey = _interpolate(request.awsv4config.secretAccessKey) || '';
request.awsv4config.sessionToken = _interpolate(request.awsv4config.sessionToken) || '';
request.awsv4config.service = _interpolate(request.awsv4config.service) || '';
request.awsv4config.region = _interpolate(request.awsv4config.region) || '';
request.awsv4config.profileName = _interpolate(request.awsv4config.profileName) || '';
}

if (request) return request;
};

module.exports = interpolateVars;