Skip to content

docs(cn): update rollup links to cn documentation #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Conversation

kovsu
Copy link
Contributor

@kovsu kovsu commented May 6, 2025

将文档中 rollup 英文文档链接更新为中文文档链接

Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cn-vitejs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 9:59am

@thinkasany
Copy link
Collaborator

thinkasany commented May 6, 2025

将文档中 rollup 英文文档链接更新为中文文档链接

其实有可能是刻意这么做的,因为 rollup 的中文站点也是 单独的仓库 维护的。 https://github.com/rollup/rollup-docs-cn

也就是说,可能会有同步错误(没有冲突的情况下可能docschina-bot 会自动合并), 或者是文档同步不及时,产生的落后信息。

应该让用户自己选择是否需要切到中文,也许有人会用 类似 (沉浸式翻译) 这样子的双语对照插件。

当然还是很感谢你辛苦的 PR~ 我来问问核心成员 @waynzh

@thinkasany thinkasany requested a review from waynzh May 6, 2025 12:17
@waynzh
Copy link
Collaborator

waynzh commented May 7, 2025

感谢贡献!对于链接是否要指向对应的中文文档还暂时没有规范。rollup 中文文档更新算比较及时,我觉得这个 PR 是可以先合并的。

@thinkasany 所述,翻译者手动替换链接到中文文档站会增加一丢丢核对的工作量,且后续 diff 可能会有影响,所以没有统一处理过。之前也参考过 vue 翻译的讨论,个人觉得之后也不需要严格的统一,但能跳转到更新及时、翻译友好的中文文档体验肯定是更好的😄

@waynzh waynzh changed the title fix: update rollup links to cn documentation docs(cn): update rollup links to cn documentation May 7, 2025
@waynzh waynzh merged commit 8838a16 into vitejs:main May 7, 2025
2 checks passed
@kovsu kovsu deleted the chore-1 branch May 7, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants