Skip to content

style: remove eslint-disable rules #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2023
Merged

style: remove eslint-disable rules #9019

merged 2 commits into from
Oct 20, 2023

Conversation

Plumbiu
Copy link
Contributor

@Plumbiu Plumbiu commented Aug 22, 2023

No description provided.

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.8 kB 32.6 kB 29.5 kB
vue.global.prod.js 132 kB 49.3 kB 44.3 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.8 kB 17.2 kB
createSSRApp 50.6 kB 19.9 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB 23.7 kB 21.6 kB

@sxzz sxzz added 🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged. labels Aug 31, 2023
@sxzz sxzz changed the base branch from main to chore/style September 7, 2023 13:47
@sxzz
Copy link
Member

sxzz commented Sep 7, 2023

I changed the base branch to chore/style. We can merge these stylistic PRs into a commit and put it into .git-blame-ignore-revs to avoid making git history messy.

@sxzz sxzz mentioned this pull request Sep 7, 2023
Merged
@yyx990803 yyx990803 merged commit 9f86f68 into vuejs:chore/style Oct 20, 2023
sxzz added a commit that referenced this pull request Dec 19, 2023
@sxzz @Plumbiu
chore: remove unused eslint-disable rules (#9019)
d133081 
Co-authored-by: Guo Xingjun <[email protected]>
sxzz added a commit that referenced this pull request Dec 19, 2023
@sxzz @Plumbiu
chore: remove unused eslint-disable rules (#9019)
d5df439 
Co-authored-by: Guo Xingjun <[email protected]>
sxzz added a commit that referenced this pull request Dec 19, 2023
@sxzz @Plumbiu
chore: remove unused eslint-disable rules (#9019)
0418d15 
Co-authored-by: Guo Xingjun <[email protected]>
sxzz added a commit that referenced this pull request Dec 19, 2023
@sxzz @Plumbiu
chore: remove unused eslint-disable rules (#9019)
00da674 
Co-authored-by: Guo Xingjun <[email protected]>
sxzz added a commit that referenced this pull request Dec 19, 2023
@sxzz @Plumbiu
chore: remove unused eslint-disable rules (#9019)
43c0107 
Co-authored-by: Guo Xingjun <[email protected]>
sxzz added a commit that referenced this pull request Dec 20, 2023
@sxzz @Plumbiu
chore: remove unused eslint-disable rules (#9019)
75d5c12 
Co-authored-by: Guo Xingjun <[email protected]>
sxzz added a commit that referenced this pull request Dec 26, 2023
@sxzz @Plumbiu
chore: remove unused eslint-disable rules (#9019)
f0dd767 
Co-authored-by: Guo Xingjun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Plumbiu @sxzz @yyx990803