Skip to content

style: remove eslint-disable rules #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2023
Merged

style: remove eslint-disable rules #9019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff68322
style: remove eslint-disable rules
Plumbiu Aug 22, 2023
37d3dae
Merge branch 'main' into main
Plumbiu Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/compiler-dom/src/decodeHtmlBrowser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable no-restricted-globals */

let decoder: HTMLDivElement

export function decodeHtmlBrowser(raw: string, asAttr = false): string {
Expand Down
2 changes: 0 additions & 2 deletions packages/dts-test/ref.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,11 @@ function bailType(arg: HTMLElement | Ref<HTMLElement>) {
expectType<HTMLElement>(unref(arg))

// ref inner type should be unwrapped
// eslint-disable-next-line no-restricted-globals
const nestedRef = ref({ foo: ref(document.createElement('DIV')) })

expectType<Ref<{ foo: HTMLElement }>>(nestedRef)
expectType<{ foo: HTMLElement }>(nestedRef.value)
}
// eslint-disable-next-line no-restricted-globals
const el = document.createElement('DIV')
bailType(el)

Expand Down
1 change: 0 additions & 1 deletion packages/reactivity-transform/src/reactivityTransform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,6 @@ export function transformAST(
const hasWarned: Record<string, boolean> = {}

function warnExperimental() {
// eslint-disable-next-line
if (typeof window !== 'undefined') {
return
}
Expand Down
2 changes: 0 additions & 2 deletions packages/reactivity/__tests__/collections/Map.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ describe('reactivity/collections', () => {
const map = reactive(new Map())
effect(() => {
dummy = 0
// eslint-disable-next-line no-unused-vars
for (let [key, num] of map) {
key
dummy += num
Expand Down Expand Up @@ -164,7 +163,6 @@ describe('reactivity/collections', () => {
effect(() => {
dummy = ''
dummy2 = 0
// eslint-disable-next-line no-unused-vars
for (let [key, num] of map.entries()) {
dummy += key
dummy2 += num
Expand Down
1 change: 0 additions & 1 deletion packages/reactivity/__tests__/collections/Set.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ describe('reactivity/collections', () => {
const set = reactive(new Set<number>())
effect(() => {
dummy = 0
// eslint-disable-next-line no-unused-vars
for (let [key, num] of set.entries()) {
key
dummy += num
Expand Down
2 changes: 0 additions & 2 deletions packages/runtime-core/src/compat/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,6 @@ function installCompatMount(

let container: Element
if (typeof selectorOrEl === 'string') {
// eslint-disable-next-line
const result = document.querySelector(selectorOrEl)
if (!result) {
__DEV__ &&
Expand All @@ -499,7 +498,6 @@ function installCompatMount(
}
container = result
} else {
// eslint-disable-next-line
container = selectorOrEl || document.createElement('div')
}

Expand Down