Skip to content

fix: set watchpack limit before loading watchpack #10236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Conversation

chenjiahan
Copy link
Member

Summary

We tried setting WATCHPACK_WATCHER_LIMIT by default in the Rspack CLI (#5486), but I found that this did not work because watchpack was loaded earlier than the WATCHPACK_WATCHER_LIMIT was set in the Rspack CLI.

image

This PR fixes the issue by setting WATCHPACK_WATCHER_LIMIT earlier in Rspack core.

Also submitted a PR to the watchpack repo: webpack/watchpack#249, if that gets merged we can remove this.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 29, 2025
Copy link

netlify bot commented Apr 29, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit aefd53f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68103e54b90e5b0008feb054

@chenjiahan chenjiahan requested a review from hardfist April 29, 2025 02:52
Copy link

netlify bot commented Apr 29, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4189959
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68103e607f2d840008faee7e

Copy link

codspeed-hq bot commented Apr 29, 2025

CodSpeed Performance Report

Merging #10236 will not alter performance

Comparing watchpack_limit_0429 (4189959) with main (d13413d)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan merged commit b137d9e into main Apr 29, 2025
63 of 70 checks passed
@chenjiahan chenjiahan deleted the watchpack_limit_0429 branch April 29, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants