-
-
Notifications
You must be signed in to change notification settings - Fork 110
perf: limit the number of concurrently open file watchers on macOS #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: limit the number of concurrently open file watchers on macOS #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with it, but can we add a test case/simple perf case to verify it and to avoid future regressions?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 92.20% 91.46% -0.75%
==========================================
Files 6 6
Lines 1065 1066 +1
Branches 258 258
==========================================
- Hits 982 975 -7
- Misses 83 91 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sure, creating a stable perf test seems difficult, so I added a simple test to check the watcher limit value |
@chenjiahan very weird, looks like Node.js@22 has regression somewhere on windows... I know it is not related to these changes... I will look deeply |
@chenjiahan sorry for delay, can you rebase? |
We fixed problem with node@22 |
5b3deb8
to
e3426af
Compare
Rebased 😄 |
Limit the number of concurrently open file watchers on macOS to 20 to make
FSWatcher.close
faster.Related PRs:
WATCHPACK_WATCHER_LIMIT=20
vercel/next.js#51826Related issues: