Skip to content

Add name/names requirement for async commons chunk #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewdushane
Copy link
Contributor

To use the async option with the CommonsChunkPlugin in the current version of webpack (3.0.0, going back to 2.5.0), a name or names option which matches entry name/s is also required. This PR changes the code example for async commons chunk to show that.

@andrewdushane
Copy link
Contributor Author

andrewdushane commented Jun 29, 2017

Travis is failing on lint:links and seems to be choking on a link to https://github.com/webpack-contrib/file-loader/edit/master/README.md
From the log:

Guessing --root from input files: file:///home/travis/build/webpack/webpack.js.org/build/
should respond with HTTP status 200
502 https://github.com/webpack-contrib/file-loader/edit/master/README.md at build/loaders/file-loader/index.html:19:59413 <a class="page-links__link" href="https://github.com/webpack-contrib/file-loader/edit/master/README.md">...</a>

@skipjack
Copy link
Collaborator

skipjack commented Jul 1, 2017

@andy-j-d I think what you saw before was just a temporary link failure (these happen fairly often) -- the other errors that cropped up after weren't related to this PR and were fixed in #1355.

@skipjack skipjack requested review from simon04 and removed request for bebraw July 9, 2017 13:37
Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, looks great! I'll just need to coordinate merging this, #1370, and #1428 as I think there's some overlap. Should be merged soon.

@skipjack skipjack merged commit 1f675ba into webpack:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants