Skip to content

name and chunks clarification #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

name and chunks clarification #1428

wants to merge 2 commits into from

Conversation

arackaf
Copy link

@arackaf arackaf commented Jul 15, 2017

  1. Read and sign the CLA. This needs to be done only once. PRs that haven't signed it won't be accepted.

signed

  1. Make sure your PR complies with the writer's guide.
  2. Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.
  3. Remove these instructions from your PR as they are for your eyes only.

@skipjack
Copy link
Collaborator

skipjack commented Jul 28, 2017

@arackaf thanks again for your contribution. As I was merging #1345 and #1370 I noticed there was a fair amount of overlap. I'm going to close as I think the changes here are covered by those two but feel free to update this branch and re-open if you think something is still missing.

Also, those comment blocks in that plugin are starting to get a bit long. Maybe we should leave examples for the bottom sections and possibly consider changing how that page is laid out at some point (i.e. moving some of the docs out of comments).

@skipjack skipjack closed this Jul 28, 2017
@arackaf
Copy link
Author

arackaf commented Jul 28, 2017

No problem - I'm glad the docs are clarified, no matter the source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants