Code analysis fixes: Refactor code for consistency and readability, i… #178
+84
−94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch cleans up Java Thread Affinity source and test code after a static-analysis sweep.
It does not change runtime behaviour; all modifications are cosmetic or defensive.
LinuxJNAAffinity
,FileLockBasedLockChecker
, many others"msg "+val
) with SLF4J parameterised messages ("msg {}", val
).AffinityLock
,LockInventory
, testsIllegalArgumentException
checks for invalidcpuId
.• Converted
assertTrue(!x)
toassertFalse(x)
for clarity.• Removed dead code comments.
AffinityThreadFactory
, several testsBootClassPath
,VersionHelper
,VanillaCpuLayout
@NotNull
,StandardCharsets.UTF_8
, and.isEmpty()
idioms.MicroJitterSampler
,JNIClock
, tests@SuppressWarnings
and IDE hints (//noinspection …
).OSGiBundleTest
,OSGiTestBase
Motivation
Improving code readability and log consistency helps: