Fix/socket close nre #73

OchirDarmaev · 2020-08-25T23:02:19Z

EngineIoClientDotNet 1.0.8 uses with SocketIoClientDotNet 1.0.8
Target build platform 4.5

It runs as mobile app built using Unity 2019.4.8f1 for iOS and Android

We have 34k NRE in the week for 22k users. After that error socket never restores connection.

2020-08-23 16:24:56.4563 [FATAL] Object reference not set to an instance of an object.
System.NullReferenceException: Object reference not set to an instance of an object.
at Quobject.EngineIoClientDotNet.Client.Socket.Close () [0x00000] in <00000000000000000000000000000000>:0
at Quobject.SocketIoClientDotNet.Client.Manager+<>c__DisplayClass51_1.b__2 () [0x00000] in <00000000000000000000000000000000>:0
at System.Action.Invoke () [0x00000] in <00000000000000000000000000000000>:0
at System.Action.Invoke () [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ContextCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.Tasks.AwaitTaskContinuation.RunCallback (System.Threading.ContextCallback callback, System.Object state, System.Threading.Tasks.Task& currentTask) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.Tasks.Task.FinishContinuations () [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.Tasks.Task`1[TResult].TrySetResult (TResult result) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.Tasks.Task+DelayPromise.Complete () [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.TimerCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.WaitCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ThreadPoolWorkQueue.Dispatch () [0x00000] in <00000000000000000000000000000000>:0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.WaitCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ContextCallback.Invoke (System.Object state) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <00000000000000000000000000000000>:0
at System.Threading.ThreadPoolWorkQueue.Dispatch () [0x00000] in <00000000000000000000000000000000>:0

Allow for TLS (HTTPS) through a web proxy when using web sockets

… for GET and POST

couldnt SendAsync for POST anymore, split into GetAsync and SendAsync for GET and POST

handle the emit in try/catch

don't ping on connection not "open"

fix the issue that I created with Quobject#50

Quobject.EngineIoClientDotNet.Client.EngineIOException: Transport not open Quobject#49

…ndefinite recursion

Proposed fix for Issue 53 - use bool OnDataReceived signal to avoid i…

By using SpinWait the operation is more cpu friendly because it will yield the thread after some time.

By only locking the file for writers, it is possible to monitor the file in realtime.

Replace StopWatch by SpinWait

Lock log file only for writing

…ew background thread for every ping request

Fixed runaway threadleak issue due around ping/heartbeats

Remove debug Console.WriteLine

…ng extra headers in old .NET Standard project. Fixes Quobject#61.

Added a new project that targets .NET Standard 2.0. Fixed a bug passi…

Exposed SslProtocols option. This will be in the next release in October 2018. I will check then that all current unit tests are passing. It would be could to have a new unit test for this functionality.

fix of leading questionmark in queryParams dictionary.

Add the SslProtocols option to .NET 3.5 and 4.0

mattqs · 2020-08-25T23:07:00Z

#69

OchirDarmaev · 2020-08-25T23:33:32Z

Hello, @mattqs I have added some description of a reason why I create a merge request

Leszek Mazur and others added 30 commits September 1, 2017 12:13

proxy support

37533e3

added TLS proxy support

9e24028

update SuperSockets to the version that supports TSL through a proxy

77d6e23

revert unnecessary changes

7259176

Merge pull request Quobject#40 from leszekm1/master

171072e

Allow for TLS (HTTPS) through a web proxy when using web sockets

1.0.3

3784f18

couldnt SendAsync for POST anymore, split into GetAsync and SendAsync…

98314b7

… for GET and POST

Merge pull request Quobject#42 from Murf/master

c44b4d2

couldnt SendAsync for POST anymore, split into GetAsync and SendAsync for GET and POST

handle in try/catch the emit

5edd066

fix issue Quobject#49

2a954c9

Merge pull request Quobject#47 from MeTaXaS4/master

13fc371

handle the emit in try/catch

Merge remote-tracking branch 'refs/remotes/Quobject/master'

f1794d0

ping only when the state is open

c340fcf

Merge pull request Quobject#50 from MeTaXaS4/master

35984f4

don't ping on connection not "open"

1.0.4

7926b00

Socket.cs else if(ReadyState == ReadyStateEnum.OPEN)

f9f9920

fix the issue that I created

9dc6243

Merge pull request Quobject#51 from MeTaXaS4/master

5f0425a

fix the issue that I created with Quobject#50

1.0.5

58b954f

Quobject.EngineIoClientDotNet.Client.EngineIOException: Transport not open Quobject#49

Proposed fix for Issue 53 - use bool OnDataReceived signal to avoid i…

641e761

…ndefinite recursion

Merge pull request Quobject#54 from hideflolife/master

1d1b022

Proposed fix for Issue 53 - use bool OnDataReceived signal to avoid i…

Replace StopWatch by SpinWait

a1b1b0c

By using SpinWait the operation is more cpu friendly because it will yield the thread after some time.

Remove unused logger implemetations

e680189

Lock log file only for writing

79359ba

By only locking the file for writers, it is possible to monitor the file in realtime.

Merge pull request Quobject#55 from KarelCoudijzer/fix/waitupgrade-async

00546fd

Replace StopWatch by SpinWait

Merge pull request Quobject#56 from KarelCoudijzer/feat/log-write-lock

7d27b99

Lock log file only for writing

Moved SetHeartbeat(PingTimeout) in Socket_net35 to avoid creating a n…

1ebec32

…ew background thread for every ping request

Merge pull request Quobject#57 from chrisprad/Threadleak

a93ce8d

Fixed runaway threadleak issue due around ping/heartbeats

1.0.6

0cca084

Remove debug Console.WriteLine. Fixes Quobject#59.

af13fd1

mattqs and others added 12 commits June 5, 2018 06:56

Merge pull request Quobject#60 from MModal/fix/59

ed511ef

Remove debug Console.WriteLine

Added a new project that targets .NET Standard 2.0. Fixed a bug passi…

407402d

…ng extra headers in old .NET Standard project. Fixes Quobject#61.

Merge pull request Quobject#62 from MModal/MModal/fix/61

49eb7be

Added a new project that targets .NET Standard 2.0. Fixed a bug passi…

1.0.7

1acbed3

Exposed SslProtocols option

3e68886

Merge pull request Quobject#64 from mamasselin/142-ssl-protocols-option

5d6ebca

Exposed SslProtocols option. This will be in the next release in October 2018. I will check then that all current unit tests are passing. It would be could to have a new unit test for this functionality.

fix of leading questionmark in queryParams dictionary.

4964356

Merge pull request Quobject#66 from pkrizan/master

b22fc00

fix of leading questionmark in queryParams dictionary.

Add the SslProtocols option to .NET 3.5 and 4.0

a8d41ad

Merge pull request Quobject#68 from gamlerhart/master

ec9feaf

Add the SslProtocols option to .NET 3.5 and 4.0

1.0.8

450672e

fix socket close NRE

d096461

mattqs closed this Aug 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix/socket close nre #73

Fix/socket close nre #73

Uh oh!

OchirDarmaev commented Aug 25, 2020 •

edited

Loading

Uh oh!

mattqs commented Aug 25, 2020

Uh oh!

OchirDarmaev commented Aug 25, 2020 •

edited

Loading

Uh oh!

Uh oh!

Fix/socket close nre #73

Fix/socket close nre #73

Uh oh!

Conversation

OchirDarmaev commented Aug 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattqs commented Aug 25, 2020

Uh oh!

OchirDarmaev commented Aug 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OchirDarmaev commented Aug 25, 2020 •

edited

Loading

OchirDarmaev commented Aug 25, 2020 •

edited

Loading