fix: Add scrollable content to modern style settings dialogs

[MarcaDian]

This fix dialog layout to prevent buttons from being pushed off-screen.

If user has set a very large font, the content does not fit into the dialog, so the buttons may go off the screen.

[LisoUseInAIKyrios]

Unrelated to this PR, but after using the new dialogs for a little while I think the AMOLED black dialog adjustment could be adjusted so the dialog background is closer to black. Maybe 5% brightness instead of 10% or whatever it is now. I think the dialog background looks a little too grey and could be closer to pure black (without being pure black).

[MarcaDian]

AMOLED black dialog adjustment could be adjusted so the dialog background is closer to black.

Actually, that's exactly what I wanted to do, but I guess overthought it a bit.
I think this can be changed in this PR.

This PR should be merged as soon as possible, because in the check dialog the buttons may be behind the screen, and it is impossible to click Ignore.
Although I haven't noticed any open issues yet.

[LisoUseInAIKyrios]

I remember if the theme color is pure black, then it uses slightly off black for the dialogs so the dialog bounds are viewable?

I still think that is the correct behavior, but I think it should use a darker shade of black.

[MarcaDian]

That's where this color is, just need to choose a darker one

revanced-patches/extensions/shared/library/src/main/java/app/revanced/extension/shared/Utils.java

Line 1216 in 98d43c8

? 0xFF0D0D0D

[MarcaDian]

Can try 0xFF050505 is 2%
0xFF080808 is 3%
0xFF0D0D0D is 5%

[MarcaDian]

3% lighter

[MarcaDian]

I don't understand where the extra paragraph comes from.

Edit: This is probably because of the <p> tag in the string resource. Have to try this

<string name="revanced_check_environment_failed_message">
    <h5>This app does not appear to be patched by you.</h5><br>
    This app may not function correctly, <b>could be harmful or even dangerous to use</b>.<br><br>
    These checks imply this app is pre-patched or obtained from someone else:<br><br>
    <small>%1$s</small><br>
    It is strongly recommended to <b>uninstall this app and patch it yourself</b> to ensure you are using a validated and secure app.<br><br>
    If ignored, this warning will only be shown twice.
</string>

[LisoUseInAIKyrios]

That dialog text is created from html converted to an Android span. It might be adding padding to match html behavior. Not sure.

Its too minor to worry about fixing it.

[LisoUseInAIKyrios]

Can merge whenever this is ready.

[MarcaDian]

Wait a bit, I still need to add scrolling in some places (colorpicker, preferencelist), I'm testing now

[MarcaDian]

Probably considered all the places where need to add a scrollview.

In the past PR I missed that the user can work in landscape orientation, or on TV, so when the content takes up a lot of space the buttons were still hidden (previously to avoid this I added a check for 60% of the height). Now everything is probably adapting as it should.

[MarcaDian]

Unrelated to this PR, but if select ReVanced language, the dialog width limit is not applied, probably due to a problem with setContext.

Nevertheless, ready to merge.

[LisoUseInAIKyrios]

Will merge tomorrow if there's no further changes by then.

[ILoveOpenSourceApplications]

The changes in this PR are exclusive towards ReVanced YouTube settings, right? So maybe change the PR title as well?

[MarcaDian]

No, the new modern dialogs are also present in other apps (Twitch), and this fix applies to them as well.

[LisoUseInAIKyrios]

Ready to merge?

[MarcaDian]

I think yes