Skip to content

Better error messages on osc #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabianofranz opened this issue Mar 31, 2015 · 5 comments
Closed

Better error messages on osc #1516

fabianofranz opened this issue Mar 31, 2015 · 5 comments
Labels
area/usability component/cli priority/P3

Comments

@fabianofranz
Copy link
Member

As a follow-up of #992 we need a reliable mechanism to customize the error messages that end up being printed in osc. Will probably require a printer of messages upstream, that is used for example by the commands under kubectl that we reuse.

We need to replace for example, for first-time users, things like No server found for with You need to log in, use 'osc login', etc.
@fabianofranz
Copy link
Member Author

@smarterclayton @deads2k fyi

@smarterclayton
Copy link
Contributor

The factory should have an interface for these sorts of things (utility messages, generic error handling).

@sosiouxme
Copy link
Member

+1000

Any chance we can intercept k8s glogs and give something user-friendly?

@smarterclayton
Copy link
Contributor

There are no more glog fatals upstream. There would only be glog errors, which should be omitting the ugly prefix when verbosity is at lower levels. That issue is still open.

@brenton
Copy link
Contributor

brenton commented May 13, 2015

I'm guessing this is related. It would be nice if login failures didn't default to dumping the error message. Here's an example of what happens when you type the wrong password and are using the RequestHeaderIdentityProvider:

[demo@dev origin]$ osc login 192.168.133.100:443
Username: demo
Authentication required for https://192.168.133.100:443 (openshift)
Password: 
Login failed (401 Unauthorized)
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>401 Unauthorized</title>
</head><body>
<h1>Unauthorized</h1>
<p>This server could not verify that you
are authorized to access the document
requested.  Either you supplied the wrong
credentials (e.g., bad password), or your
browser doesn't understand how to supply
the credentials required.</p>
</body></html>

Here's another issue that shows what happens when token expires: #2132. It definitely seems weird to print "Unauthorized" twiece whenever tokens expire.

@smarterclayton smarterclayton modified the milestone: 1.1.0 Jun 17, 2015
@jwforres jwforres removed this from the 1.1.0 milestone Sep 29, 2015
jboyd01 pushed a commit to jboyd01/origin that referenced this issue Nov 3, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
23a8ca3 
…service-catalog/' changes from 892b0368f0..3064247d05

3064247d05 origin build: add origin tooling
48ecff1 Chart changes for 0.1.2 (openshift#1527)
8727247 Fix change validator to look up serviceclass properly (openshift#1518)
b0b138b Broker Reconciliation occurs too frequently (openshift#1514)
cc816eb When a SI is unbindable, mark the binding request failed. (openshift#1522)
41290e9 Clarify semantics around RelistDuration (openshift#1516)
6bcb593 Send Context with UpdateInstanceRequest (openshift#1517)
c3b72d8 Enforce stricly increasing broker relistRequests (openshift#1515)
01d81e5 Follow up from openshift#1450 and openshift#1444 (openshift#1504)
5e77882 Retry failed deprovision requests (openshift#1505)
f6c891d Allow updates of instances that failed a previous update. (openshift#1502)
5107086 Use Plan ID from ExternalProperties when deprovisioning instance (openshift#1501)
d897c60 Adding message builder for expected event strings  (openshift#1465)
9f6152e update osb client and freeze gorilla context (openshift#1496)
c63277e Add unit tests verifying deleting a resource with an on-going operation or in orphan mitigation. (openshift#1490)
4ecca16 Pretty logging for controller_instance.go (openshift#1472)
c232db4 Register qemu statics when building non-amd64 images (openshift#1494)
0e54c57 fix 'Spring Cloud Services -> Configuring with Vault' link in docs (openshift#1495)
REVERT: 892b0368f0 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 3064247d0544aa43f976d93caea0a11771434ef7
jpeeler pushed a commit to jpeeler/origin that referenced this issue Feb 1, 2018
@kibbles-n-bytes
Clarify semantics around RelistDuration (openshift#1516)
41290e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/usability component/cli priority/P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@brenton @sosiouxme @fabianofranz @danmcp @liggitt @smarterclayton @jwforres