WIP: Test PushSecretName via extended tests #1515
Conversation
mfojtik
force-pushed
the
build_secret_extended
branch
2 times, most recently
from
f2ff992 to
867e146
Compare
| local image=$1 | ||
| local registry=$2 | ||
| echo "[INFO] Caching $image to $registry" | ||
| ( docker pull $image && \ |
There was a problem hiding this comment.
I'm not sure we want to do this pull because IIRC we build those images locally when doing full test inside jenkins. So this might overwrite them, which is not what we'd expect. The same might be true for local as well. In all other cases where you'd actually wanted to pull them I'd would add flag to those tests to do so.
There was a problem hiding this comment.
+1, should probably just tag+push without doing the pull, if these are images that are part of the build.
There was a problem hiding this comment.
looks like it's being used for images that aren't part of the origin build, so it should be ok.
There was a problem hiding this comment.
Actually openshift/origin-custom-docker-builder is part of that build and openshift/ruby-20-centos7 should be already inside the image, so IMHO it's safer not to pull them.
|
I like the overall structure of the tests, they are clean and easily understandable. Good work @mfojtik! |
mfojtik
force-pushed
the
build_secret_extended
branch
2 times, most recently
from
7361f4f to
ac7f2aa
Compare
|
LGTM |
mfojtik
force-pushed
the
build_secret_extended
branch
from
ac7f2aa to
c7d6009
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1657/) (Image: devenv-fedora_1188) |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1657/) |
|
Evaluated for origin up to c7d6009 |
|
[merge] again |
…service-catalog/' changes from 892b0368f0..3064247d05 3064247d05 origin build: add origin tooling 48ecff1 Chart changes for 0.1.2 (openshift#1527) 8727247 Fix change validator to look up serviceclass properly (openshift#1518) b0b138b Broker Reconciliation occurs too frequently (openshift#1514) cc816eb When a SI is unbindable, mark the binding request failed. (openshift#1522) 41290e9 Clarify semantics around RelistDuration (openshift#1516) 6bcb593 Send Context with UpdateInstanceRequest (openshift#1517) c3b72d8 Enforce stricly increasing broker relistRequests (openshift#1515) 01d81e5 Follow up from openshift#1450 and openshift#1444 (openshift#1504) 5e77882 Retry failed deprovision requests (openshift#1505) f6c891d Allow updates of instances that failed a previous update. (openshift#1502) 5107086 Use Plan ID from ExternalProperties when deprovisioning instance (openshift#1501) d897c60 Adding message builder for expected event strings (openshift#1465) 9f6152e update osb client and freeze gorilla context (openshift#1496) c63277e Add unit tests verifying deleting a resource with an on-going operation or in orphan mitigation. (openshift#1490) 4ecca16 Pretty logging for controller_instance.go (openshift#1472) c232db4 Register qemu statics when building non-amd64 images (openshift#1494) 0e54c57 fix 'Spring Cloud Services -> Configuring with Vault' link in docs (openshift#1495) REVERT: 892b0368f0 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 3064247d0544aa43f976d93caea0a11771434ef7
Signed-off-by: Jonathan Berkhahn <[email protected]>
This PR is: