Handle unexpected server errors more thoroughly in RequestToken #1502
Conversation
| @@ -24,6 +24,7 @@ func NewDefaultServerConfig() *osin.ServerConfig { | |||
| config.AllowClientSecretInParams = true | |||
| config.AllowGetAccessRequest = true | |||
| config.RedirectUriSeparator = "," | |||
| config.ErrorStatusCode = http.StatusInternalServerError | |||
There was a problem hiding this comment.
Shouldn't this be: StatusBadRequest as per: https://tools.ietf.org/html/rfc6749#section-5.2?
There was a problem hiding this comment.
The error we were actually generating (server_error) was 500. Since all we have is a hammer....
On Mar 30, 2015, at 2:36 PM, David Eads [email protected] wrote:
In pkg/oauth/server/osinserver/defaults.go:
@@ -24,6 +24,7 @@ func NewDefaultServerConfig() *osin.ServerConfig {
config.AllowClientSecretInParams = true
config.AllowGetAccessRequest = true
config.RedirectUriSeparator = ","
- config.ErrorStatusCode = http.StatusInternalServerError
Shouldn't this be: StatusBadRequest as per: https://tools.ietf.org/html/rfc6749#section-5.2?—
Reply to this email directly or view it on GitHub.
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1347/) (Image: devenv-fedora_1166) |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1524/) |
|
Fixes #1497 |
Also ensures the OSIN server returns a 400 on generic error cases as per the OAuth2 spec.
smarterclayton
force-pushed
the
handle_server_auth_errors
branch
from
2f517e1 to
e6d8354
Compare
|
Rebased |
|
I mean, fixed. |
|
[merge] |
|
Evaluated for origin up to e6d8354 |
Merged by openshift-bot
…service-catalog/' changes from 892b0368f0..3064247d05 3064247d05 origin build: add origin tooling 48ecff1 Chart changes for 0.1.2 (openshift#1527) 8727247 Fix change validator to look up serviceclass properly (openshift#1518) b0b138b Broker Reconciliation occurs too frequently (openshift#1514) cc816eb When a SI is unbindable, mark the binding request failed. (openshift#1522) 41290e9 Clarify semantics around RelistDuration (openshift#1516) 6bcb593 Send Context with UpdateInstanceRequest (openshift#1517) c3b72d8 Enforce stricly increasing broker relistRequests (openshift#1515) 01d81e5 Follow up from openshift#1450 and openshift#1444 (openshift#1504) 5e77882 Retry failed deprovision requests (openshift#1505) f6c891d Allow updates of instances that failed a previous update. (openshift#1502) 5107086 Use Plan ID from ExternalProperties when deprovisioning instance (openshift#1501) d897c60 Adding message builder for expected event strings (openshift#1465) 9f6152e update osb client and freeze gorilla context (openshift#1496) c63277e Add unit tests verifying deleting a resource with an on-going operation or in orphan mitigation. (openshift#1490) 4ecca16 Pretty logging for controller_instance.go (openshift#1472) c232db4 Register qemu statics when building non-amd64 images (openshift#1494) 0e54c57 fix 'Spring Cloud Services -> Configuring with Vault' link in docs (openshift#1495) REVERT: 892b0368f0 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 3064247d0544aa43f976d93caea0a11771434ef7
…1502) * Allow updates of instances that failed a previous update. * Do not set Failed condition when instance update fails
Also ensures the OSIN server returns a 500 on generic error cases
as per the OAuth2 spec.
@deads2k