[Hardware Wallet Support Grant Milestone 2] ECDSA Custom Signature Pallet UI implementation #4435
Conversation
There was a problem hiding this comment.
It is great that it works, well done. Having said that, there are a couple of issues I see -
- It is not actually integrated with the signer, so we have a completely seperate process
- Accounts are completely seperate from the account accounts page
To do it correctly, when the call is available, it needs to allow addition on the Accounts page.
Then when sent, the Signer will detect the account and perform wrapping as required.
An additional concern is the way the extension is integrated, see for instance polkadot-js/extension#566 which the uses the existing extension interface.
|
thank you for your feedback @jacogr. |
Co-authored-by: Daelon02 <[email protected]>
skip-checks: true
* Bump deps * Use override * additional override
skip-checks: true
skip-checks: true
skip-checks: true
Co-authored-by: Daelon02 <[email protected]>
skip-checks: true
* OriginTrail parachain changes * Add OriginTrail Parachain to polkadotjs * Rename assets * Resolve lint issues * Change order * Update logo mapping and paraId Co-authored-by: Nikola Todorovic <[email protected]>
skip-checks: true
* Warn on staking min bond * Warn on min validator amount
skip-checks: true
skip-checks: true
skip-checks: true
…polkadot-js#5678) * Added Pinknode endpoints for Polkadot, Kusama, Rococo, Westend * Added Pinknode endpoints for Acala Mandala, Crust Rocky, Dusty, Nodle
skip-checks: true
skip-checks: true
skip-checks: true
skip-checks: true
skip-checks: true
skip-checks: true
* add provider for karura and moonriver * Add Elara bifrost kusama provider
skip-checks: true
Co-authored-by: Daelon02 <[email protected]>
skip-checks: true
skip-checks: true
skip-checks: true
skip-checks: true
* add chainType to metadata in the qr code * lint
skip-checks: true
skip-checks: true
skip-checks: true
|
whoops. I shouldn't have rebased it. Sorry, this was an amateur mistake on my side. I'll close this PR and open a clean one later! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Feature Summary
This pull request adds the Custom Signature page under the Account tab.
The Custom Signature page allows the user to submit a transaction that was signed with an Ethereum private key and use it as a native ECDSA account in Substrate. Plus, you are able to use MetaMask for signature requests, which allows users to use their Ethereum address inside Ledger and Trezor to create a transaction.
Preview
Ledger
ecdsa-sig-final.mp4
Trezor
Screen.Recording.2021-08-02.at.12.49.24.PM.mov
Notable Changes
assertbrowser polyfill that is used by theethereumjs-utilpackagecustom-signaturepage that will be available for chains that implement thecustom-signaturespallet (https://github.com/PlasmNetwork/Plasm/tree/dusty/frame/custom-signatures) asEthCall(https://github.com/PlasmNetwork/Plasm/blob/feature/vectorized-custom-signatures/bin/node/runtime/src/lib.rs#L649)Usage
Currently, this page is made with MetaMask in mind. Most browser-injected ethereum wallets that use the
window.ethereumobject and accept thepersonal_signmethod should be compatible, but please understand that there may be unexpected errors.You can learn more about the usage from this doc: https://docs.plasmnet.io/build/metamask-signatures